feat(stripe): reuse customers and save cards for off-session reuse#239
feat(stripe): reuse customers and save cards for off-session reuse#239Tarunkumar0601 wants to merge 4 commits into
Conversation
|
Tick the box to add this pull request to the merge queue (same as
|
Confidence Score: 3/5Safe to merge for synchronous card payments only; async payment methods (SEPA, ACH, bank transfers) are silently never settled, and subscription price sync is broken due to a missing database column. The synchronous card payment path (both Hosted Checkout and Embedded Elements) is well-guarded and largely correct. However, the async payment settlement path redirects buyers to the success page without ever finalising the ERPNext document — a webhook handler that the code explicitly relies on does not exist in this PR. Separately, the subscription sync writes to a database column (product_price_id on Subscription Plan) that the custom-field installer never creates, so every sync invocation logs an error and no Stripe price ID is ever persisted. payments/payment_gateways/doctype/stripe_settings/stripe_settings.py (missing webhook endpoint for async settlement), payments/payment_gateways/stripe_subscription_sync.py + payments/utils/utils.py (product_price_id column absent from Subscription Plan custom fields) Reviews (20): Last reviewed commit: "feat(stripe): reuse customers and save c..." | Re-trigger Greptile |
3bd83a2 to
a7acee0
Compare
a7acee0 to
1c673c7
Compare
1c673c7 to
d07e236
Compare
5fa9596 to
767050f
Compare
1a77e37 to
4f4e9eb
Compare
4f4e9eb to
5d265c5
Compare
0ccfdfe to
5b77acc
Compare
966199f to
9a7e5f9
Compare
9a7e5f9 to
58169e3
Compare
77af09c to
1ffd0e2
Compare
1ffd0e2 to
0fe9aff
Compare
0fe9aff to
30e3095
Compare
Ties each payment to a reusable Stripe Customer and saves the card for later (off-session) charging.
Prerequisite for subscriptions / recurring billing. Depends on feat/stripe-payment-intents-checkout.
Backport Needed: V15 & V16